netdev - Re: [PATCH] bridge: dont send notification when skb->len == 0 in rtnl_bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54C8EBD0.4090502@cumulusnetworks.com>
Date:	Wed, 28 Jan 2015 06:01:52 -0800
From:	roopa <roopa@...ulusnetworks.com>
To:	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org, stephen@...workplumber.org,
	rami.rosen@...el.com
Subject: Re: [PATCH] bridge: dont send notification when skb->len == 0 in
 rtnl_bridge_notify

On 1/28/15, 5:37 AM, roopa wrote:
> On 1/27/15, 11:05 PM, David Miller wrote:
>> From: roopa@...ulusnetworks.com
>> Date: Tue, 27 Jan 2015 21:46:24 -0800
>>
>>> From: Roopa Prabhu <roopa@...ulusnetworks.com>
>>>
>>> Reported in: https://bugzilla.kernel.org/show_bug.cgi?id=92081
>>>
>>> This patch avoids calling rtnl_notify if the device ndo_bridge_getlink
>>> handler does not return any bytes in the skb.
>>>
>>> Alternately, the skb->len check can be moved inside rtnl_notify.
>>>
>>> For the bridge vlan case described in 92081, there is also a fix needed
>>> in bridge driver to generate a proper notification. Will fix that in
>>> subsequent patch.
>>>
>>> Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com>
>> This doesn't apply to the 'net' tree, is there something I missed?
> sorry, that's me. This should be net-next. Resubmitting with net-next 
> in the PATCH line.
>
A few more details ...
....This bug exists in 'net' tree (and I believe previous releases) as 
well.
However my patch was generated on net-next, And there are other changes 
in the related area in net-next tree hence the patch will not apply on 
'net'.
Looks like its better for me to regenerate and submit against 'net'.  
will do.

Thanks,
Roopa


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html