netdev - Re: [PATCH v2] bridge: dont send notification when skb->len == 0 in rtnl_bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150128.222228.633694287669808879.davem@davemloft.net>
Date:	Wed, 28 Jan 2015 22:22:28 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	roopa@...ulusnetworks.com
Cc:	netdev@...r.kernel.org, stephen@...workplumber.org,
	rami.rosen@...el.com
Subject: Re: [PATCH v2] bridge: dont send notification when skb->len == 0
 in rtnl_bridge_notify

From: roopa@...ulusnetworks.com
Date: Wed, 28 Jan 2015 16:23:11 -0800

> From: Roopa Prabhu <roopa@...ulusnetworks.com>
> 
> Reported in: https://bugzilla.kernel.org/show_bug.cgi?id=92081
> 
> This patch avoids calling rtnl_notify if the device ndo_bridge_getlink
> handler does not return any bytes in the skb.
> 
> Alternately, the skb->len check can be moved inside rtnl_notify.
> 
> For the bridge vlan case described in 92081, there is also a fix needed
> in bridge driver to generate a proper notification. Will fix that in
> subsequent patch.
> 
> v2: rebase patch on net tree
> 
> Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html