netdev - Re: [PATCH net-next] pkt_sched: fq: remove useless TIME

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150128.232421.1780933715008005387.davem@davemloft.net>
Date:	Wed, 28 Jan 2015 23:24:21 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] pkt_sched: fq: remove useless TIME_WAIT check

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 28 Jan 2015 06:06:36 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> TIME_WAIT sockets are not owning any skb.
> 
> ip_send_unicast_reply() and tcp_v6_send_response() both use
> regular sockets.
> 
> We can safely remove a test in sch_fq and save one cache line miss,
> as sk_state is far away from sk_pacing_rate.
> 
> Tested at Google for about one year.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html