netdev - Re: [PATCH] net, ethernet, LLVMLinux: Add missing MODULE_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yw1xlhklbzab.fsf@unicorn.mansr.com>
Date:	Thu, 29 Jan 2015 11:29:32 +0000
From:	Måns Rullgård <mans@...sr.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	David Miller <davem@...emloft.net>, behanw@...verseincode.com,
	sathya.perla@...lex.com, ajit.khaparde@...lex.com,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	subbu.seetharaman@...lex.com
Subject: Re: [PATCH] net, ethernet, LLVMLinux: Add missing MODULE_DEVICE_TABLE()

Arnd Bergmann <arnd@...db.de> writes:

> On Wednesday 28 January 2015 22:42:28 David Miller wrote:
>> From: Behan Webster <behanw@...verseincode.com>
>> Date: Wed, 28 Jan 2015 17:36:14 -0800
>> 
>> > Missing MODULE_DEVICE_TABLE for pci ids from benet driver found by clang.
>> > 
>> > Signed-off-by: Behan Webster <behanw@...verseincode.com>
>> > Suggested-by: Arnd Bergmann <arnd@...db.de>
>> 
>> Why are you removing the device table?
>
> Behan took a patch that I did earlier and split it up to add descriptions.
> The patch is correct, but he either misunderstood or misexpressed the
> intention.
>
> This driver has two identical lines that both say 
>
> MODULE_DEVICE_TABLE(pci, be_dev_ids);
>
> I don't remember the exact symptom, but llvm/clang trips over this, while gcc
> silently ignores the second one.

GCC is probably being "helpful" and allowing multiple identical
definitions even though the C spec does not.  Obviously all but one
should go away.  No need to mention llvm, IMO.

-- 
Måns Rullgård
mans@...sr.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html