netdev - Re: [PATCH V2 1/6] rtlwifi: Change logging level for key change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54CBA794.90508@lwfinger.net>
Date:	Fri, 30 Jan 2015 09:47:32 -0600
From:	Larry Finger <Larry.Finger@...inger.net>
To:	kvalo@...eaurora.org
CC:	linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH V2 1/6] rtlwifi: Change logging level for key change

On 01/26/2015 02:42 PM, Larry Finger wrote:
> A recent change in key handling included logging of these changes for
> all debug levels. Such key changes should only be logged when a high
> level of debugging is enabled.
>
> Signed-off-by: Larry Finger <Larry.Finger@...inger.net>
> ---
>   drivers/net/wireless/rtlwifi/cam.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/cam.c b/drivers/net/wireless/rtlwifi/cam.c
> index 3ef870d..6e64792 100644
> --- a/drivers/net/wireless/rtlwifi/cam.c
> +++ b/drivers/net/wireless/rtlwifi/cam.c
> @@ -406,7 +406,7 @@ u8 rtl_cam_get_free_entry(struct ieee80211_hw *hw, struct ieee80211_sta *sta,
>   		}
>   	}
>   	if (found) {
> -		RT_TRACE(rtlpriv, COMP_SEC, DBG_EMERG,
> +		RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG,
>   			 "key_index=%d,cam_bitmap: 0x%x entry_idx=%d\n",
>   			  key_index, rtlpriv->sec.cam_bitmap, entry_idx);
>   		return entry_idx;
>

Kalle,

Please include this patch even though the rest of this set should be dropped. 
Once the wifi-BT communications problem is resolved, new versions of those will 
be presented.

I'm sorry that my commit message was not as informative as it could have been. I 
was presented with this material that I did not understand. One saving grace is 
that the RTL8812AE hardware is apparently rare - I certainly do not have any 
samples. I'm not sure of the value of a 1x1 implementation of 802.11ac, but that 
may be another example of my ignorance.

Thanks,

Larry
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html