netdev - Re: [PATCH] net/tulip: don't warn about unknown ARM architecture

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 30 Jan 2015 14:08:15 -0800
From:	Grant Grundler <grantgrundler@...il.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	"open list:TULIP NETWORK DRI..." <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	linux-arm-kernel@...ts.infradead.org,
	open list <linux-kernel@...r.kernel.org>,
	Grant Grundler <grundler@...isc-linux.org>
Subject: Re: [PATCH] net/tulip: don't warn about unknown ARM architecture

On Fri, Jan 30, 2015 at 1:58 PM, Arnd Bergmann <arnd@...db.de> wrote:
> ARM has 32-byte cache lines, which according to the comment in
> the init registers function seems to work best with the default
> value of 0x4800 that is also used on sparc and parisc.
>
> This adds ARM to the same list, to use that default but no
> longer warn about it.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Acked-by: Grant Grundler <grundler@...isc-linux.org>

thanks!
grant

> diff --git a/drivers/net/ethernet/dec/tulip/winbond-840.c b/drivers/net/ethernet/dec/tulip/winbond-840.c
> index 6aa887e0e1cb..9beb3d34d4ba 100644
> --- a/drivers/net/ethernet/dec/tulip/winbond-840.c
> +++ b/drivers/net/ethernet/dec/tulip/winbond-840.c
> @@ -904,7 +904,7 @@ static void init_registers(struct net_device *dev)
>         }
>  #elif defined(__powerpc__) || defined(__i386__) || defined(__alpha__) || defined(__ia64__) || defined(__x86_64__)
>         i |= 0xE000;
> -#elif defined(CONFIG_SPARC) || defined (CONFIG_PARISC)
> +#elif defined(CONFIG_SPARC) || defined (CONFIG_PARISC) || defined(CONFIG_ARM)
>         i |= 0x4800;
>  #else
>  #warning Processor architecture undefined
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html