netdev - Re: [PATCH net] qlge: Fix qlge_update_hw_vlan_features to handle if interface is down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 30 Jan 2015 23:40:17 +0000
From:	Harish Patil <harish.patil@...gic.com>
To:	Marcelo Ricardo Leitner <mleitner@...hat.com>,
	netdev <netdev@...r.kernel.org>
CC:	"cdupuis@...hat.com" <cdupuis@...hat.com>
Subject: Re: [PATCH net] qlge: Fix qlge_update_hw_vlan_features to handle if
 interface is down

>
>Currently qlge_update_hw_vlan_features() will always first put the
>interface down, then update features and then bring it up again. But it
>is possible to hit this code while the adapter is down and this causes a
>non-paired call to napi_disable(), which will get stuck.
>
>This patch fixes it by skipping these down/up actions if the interface
>is already down.
>
>Fixes: a45adbe8d352 ("qlge: Enhance nested VLAN (Q-in-Q) handling.")
>Cc: Harish Patil <harish.patil@...gic.com>
>Signed-off-by: Marcelo Ricardo Leitner <mleitner@...hat.com>
>---
> drivers/net/ethernet/qlogic/qlge/qlge_main.c | 26
>++++++++++++++++----------
> 1 file changed, 16 insertions(+), 10 deletions(-)


Acked-by: Harish Patil <harish.patil@...gic.com>

Thanks,
Harish




________________________________

This message and any attached documents contain information from the sending company or its parent company(s), subsidiaries, divisions or branch offices that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.