| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150131043436.GA27564@gondor.apana.org.au> Date: Sat, 31 Jan 2015 15:34:37 +1100 From: Herbert Xu <herbert@...dor.apana.org.au> To: Thomas Graf <tgraf@...g.ch> Cc: davem@...emloft.net, netdev@...r.kernel.org, ying.xue@...driver.com Subject: Re: [PATCH 2/6] rhashtable: Use a single bucket lock for sibling buckets Thomas Graf <tgraf@...g.ch> wrote: > rhashtable currently allows to use a bucket lock per bucket. This > requires multiple levels of complicated nested locking because when > resizing, a single bucket of the smaller table will map to two > buckets in the larger table. So far rhashtable has explicitly locked > both buckets in the larger table. > > By excluding the highest bit of the hash from the bucket lock map and > thus only allowing locks to buckets in a ratio of 1:2, the locking > can be simplified a lot without losing the benefits of multiple locks. > Larger tables which benefit from multiple locks will not have a single > lock per bucket anyway. > > Signed-off-by: Thomas Graf <tgraf@...g.ch> Thomas, could you please hold off on these changes? They totally conflict with my rehash work, which is going to render these changes moot anyway since it'll completely change how expansion/shrinking works. Thanks, -- Email: Herbert Xu <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists