netdev - Re: [PATCH net 0/4] Fix checksum error when using stacked vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150130.180428.771210305278357485.davem@davemloft.net>
Date:	Fri, 30 Jan 2015 18:04:28 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	makita.toshiaki@....ntt.co.jp
Cc:	linux.nics@...el.com, e1000-devel@...ts.sourceforge.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH net 0/4] Fix checksum error when using stacked vlan

From: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
Date: Thu, 29 Jan 2015 20:37:06 +0900

> When I was testing 802.1ad, I found several drivers don't take into
> account 802.1ad or multiple vlans when retrieving L3 (IP/IPv6) or
> L4 (TCP/UDP) protocol for checksum offload.
> 
> It is mainly due to vlan_get_protocol(), which extracts ether type only
> when it is tagged with single 802.1Q. When 802.1ad is used or there are
> multiple vlans, it extracts vlan protocol and drivers cannot determine
> which L3/L4 protocol is used.
> 
> Those drivers, most of which have IP_CSUM/IPV6_CSUM features, get L3/L4
> header-offset by software, so it seems that their checksum offload works
> with multiple vlans if we can parse protocols correctly.
> (They know mac header length, and probably don't care about what is in it.)
> 
> And another thing, some of Intel's drivers seem to use skb->protocol where
> vlan_get_protocol() is more suitable.
> 
> I tested that at least igb/igbvf on I350 works with this patch set.
> 
> Note:
> We can hand a double tagged packet with CHECKSUM_PARTIAL to a HW driver
> by creating a vlan device on a bridge device and enabling vlan_filtering
> of the bridge with 802.1ad protocol.

Series applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html