lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150202084443.GS13046@secunet.com> Date: Mon, 2 Feb 2015 09:44:43 +0100 From: Steffen Klassert <steffen.klassert@...unet.com> To: Nicolas Dichtel <nicolas.dichtel@...nd.com> CC: Fan Du <fan.du@...el.com>, <herbert@...dor.apana.org.au>, <davem@...emloft.net>, <netdev@...r.kernel.org>, <fengyuleidian0615@...il.com> Subject: Re: [PATCHv3, ipsec-next] xfrm: Do not parse 32bits compiled xfrm netlink msg on 64bits host On Thu, Jan 29, 2015 at 11:29:51AM +0100, Nicolas Dichtel wrote: > A way to solve this problem was to provide to userland a xfrm compat header > file, which match the ABI of the kernel. Something like: > > #include <linux/xfrm.h> > > #define xfrm_usersa_info xfrm_usersa_info_64 > #define xfrm_usersa_info_compat xfrm_usersa_info > struct xfrm_usersa_info_compat { > struct xfrm_selector sel; > struct xfrm_id id; > xfrm_address_t saddr; > struct xfrm_lifetime_cfg lft; > struct xfrm_lifetime_cur curlft; > struct xfrm_stats stats; > __u32 seq; > __u32 reqid; > __u16 family; > __u8 mode; > __u8 replay_window; > __u8 flags; > __u8 hole1; > __u32 hole2; > }; > > The point I try to make is that patching userland apps allows to use xfrm on a > 32bits userland / 64bits kernel. Ugh, I did not know that this is used that way. Which applications do this? So the situation is worse than I thought. What happens to such applications if we add a compat layer in the kernel? I'd guess they will break, right? > > If I understand well your patch, it will not be possible anymore, all messages > will be rejected. And this may break existing apps. This patch would have been a quick solution without the case you mentioned. Now I fear we can't fix all cases, something will remain broken. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists