netdev - Re: [PATCH net] sunvnet: set queue mapping when doing packet copies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150202.182114.1495760209878504465.davem@davemloft.net>
Date:	Mon, 02 Feb 2015 18:21:14 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	david.stevens@...cle.com
Cc:	netdev@...r.kernel.org, sowmini.varadhan@...cle.com,
	eric.dumazet@...il.com
Subject: Re: [PATCH net] sunvnet: set queue mapping when doing packet copies

From: David L Stevens <david.stevens@...cle.com>
Date: Fri, 30 Jan 2015 12:29:45 -0500

> 
> 
> This patch fixes a bug where vnet_skb_shape() didn't set the already-selected
> queue mapping when a packet copy was required. This results in using the
> wrong queue index for stops/starts, hung tx queues and watchdog timeouts
> under heavy load.
> 
> Signed-off-by: David L Stevens <david.stevens@...cle.com>
> Acked-by: Sowmini Varadhan <sowmini.varadhan@...cle.com>
> 
> --
> I'm resubmitting this in its original form. Since skb_segment() doesn't do
> TCP flow control either, due to an incorrect destructor check, and those
> issues raised by Eric are a matter of fairness, while this missing queue_mapping
> assignment results in crashes, I'd like to get this piece fixed separately.

Fair enough, applied.

Please sort out the callback issues with Eric, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html