netdev - RE: [PATCH] hyper-v: allow access to vmbus from userspace driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY2PR0301MB0711A572E3AB511365CBC58DA03D0@BY2PR0301MB0711.namprd03.prod.outlook.com>
Date:	Tue, 3 Feb 2015 21:21:09 +0000
From:	KY Srinivasan <kys@...rosoft.com>
To:	KY Srinivasan <kys@...rosoft.com>,
	Stephen Hemminger <stephen@...workplumber.org>,
	Haiyang Zhang <haiyangz@...rosoft.com>
CC:	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH] hyper-v: allow access to vmbus from userspace driver



> -----Original Message-----
> From: devel [mailto:driverdev-devel-bounces@...uxdriverproject.org] On
> Behalf Of KY Srinivasan
> Sent: Tuesday, February 3, 2015 11:24 AM
> To: Stephen Hemminger; Haiyang Zhang
> Cc: devel@...uxdriverproject.org; netdev@...r.kernel.org
> Subject: RE: [PATCH] hyper-v: allow access to vmbus from userspace driver
> 
> 
> 
> > -----Original Message-----
> > From: Stephen Hemminger [mailto:stephen@...workplumber.org]
> > Sent: Tuesday, February 3, 2015 11:04 AM
> > To: KY Srinivasan; Haiyang Zhang
> > Cc: devel@...uxdriverproject.org; netdev@...r.kernel.org
> > Subject: [PATCH] hyper-v: allow access to vmbus from userspace driver
> >
> > Brocade is submitting a hyper-v driver for DPDK <dev@...k.org> but
> > this driver needs a hook in the hyper-v bus layer to allow the
> > additional hv_uio driver to access the shared vmbus pages. The hv_uio
> > driver lives in DPDK (like
> > igb_uio) and provides userspace access to raw network packets.
> >
> > Signed-off-by: Stas Egorov <segorov@...antis.com>
> > Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>
> >
> > ---
> >  drivers/hv/connection.c |   20 +++++++++++++++++---
> >  include/linux/hyperv.h  |    3 +++
> >  2 files changed, 20 insertions(+), 3 deletions(-)
> >
> > --- a/drivers/hv/connection.c	2015-02-03 10:58:51.751752450 -0800
> > +++ b/drivers/hv/connection.c	2015-02-03 10:58:51.751752450 -0800
> > @@ -64,6 +64,21 @@ static __u32 vmbus_get_next_version(__u3
> >  	}
> >  }
> >
> > +static const uuid_le HV_NET_GUID = {
> > +	.b = {
> > +		0x63, 0x51, 0x61, 0xf8, 0x3e, 0xdf, 0xc5, 0x46,
> > +		0x91, 0x3f, 0xf2, 0xd2, 0xf9, 0x65, 0xed, 0x0e
> > +	}
> > +};
> > +
> 
> We already have this guid defined in linux/hyperv.h; look at HV_NIC_GUID.
> 
> > +void vmbus_get_pages(unsigned long *int_page, unsigned long
> > +monitor_pages[2]) {
> > +	*int_page = (unsigned long)vmbus_connection.int_page;
> > +	monitor_pages[0] = (unsigned
> > long)vmbus_connection.monitor_pages[0];
> > +	monitor_pages[1] = (unsigned
> > long)vmbus_connection.monitor_pages[1];
> > +}
> > +EXPORT_SYMBOL_GPL(vmbus_get_pages);

vmbus_get_pages() is too generic. Perhaps vmbus_get_monitor_pages() may be a better
name for this function.

Regards,

K. Y
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html