lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20150202.190049.1051229698764700160.davem@davemloft.net>
Date:	Mon, 02 Feb 2015 19:00:49 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	rvatsavayi@...iumnetworks.com
Cc:	netdev@...r.kernel.org, derek.chickles@...iumnetworks.com,
	satananda.burla@...iumnetworks.com,
	felix.manlunas@...iumnetworks.com,
	raghu.vatsavayi@...iumnetworks.com
Subject: Re: [PATCH net-next v4] Add support of Cavium Liquidio ethernet
 adapters

From: Raghu Vatsavayi <rvatsavayi@...iumnetworks.com>
Date: Fri, 30 Jan 2015 18:29:38 -0800

>  create mode 100644 drivers/net/ethernet/cavium/liquidio/cn66xx_device.c
 ...
>  create mode 100644 drivers/net/ethernet/cavium/liquidio/cn68xx_device.c

These two file have several functions which are nearly identical.

Especially the device init register programming sequence.

Please consolidate the common code some more.

THanks.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists