netdev - Re: [PATCHv1 net] xen-netback: stop the guest rx thread after a fatal error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150202.193922.1020681915054887138.davem@davemloft.net>
Date:	Mon, 02 Feb 2015 19:39:22 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	david.vrabel@...rix.com
Cc:	netdev@...r.kernel.org, xen-devel@...ts.xenproject.org,
	ian.campbell@...rix.com, wei.liu2@...rix.com
Subject: Re: [PATCHv1 net] xen-netback: stop the guest rx thread after a
 fatal error

From: David Vrabel <david.vrabel@...rix.com>
Date: Mon, 2 Feb 2015 16:57:51 +0000

> After commit e9d8b2c2968499c1f96563e6522c56958d5a1d0d (xen-netback:
> disable rogue vif in kthread context), a fatal (protocol) error would
> leave the guest Rx thread spinning, wasting CPU time.  Commit
> ecf08d2dbb96d5a4b4bcc53a39e8d29cc8fef02e (xen-netback: reintroduce
> guest Rx stall detection) made this even worse by removing a
> cond_resched() from this path.
> 
> Since a fatal error is non-recoverable, just allow the guest Rx thread
> to exit.  This requires taking additional refs to the task so the
> thread exiting early is handled safely.
> 
> Signed-off-by: David Vrabel <david.vrabel@...rix.com>
> Reported-by: Julien Grall <julien.grall@...aro.org>
> Tested-by: Julien Grall <julien.grall@...aro.org>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html