netdev - [RFC] NAPI behavior when (work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <2015045.8auvsRvBkK@lx-wigig-72>
Date:	Wed, 4 Feb 2015 15:22:38 +0200
From:	Vladimir Kondratiev <QCA_vkondrat@....qualcomm.com>
To:	<netdev@...r.kernel.org>
CC:	"David S. Miller" <davem@...emloft.net>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Eric Dumazet <edumazet@...gle.com>,
	Tom Herbert <therbert@...gle.com>,
	Vlad Yasevich <vyasevic@...hat.com>,
	Jiri Pirko <jiri@...nulli.us>,
	John Fastabend <john.fastabend@...il.com>,
	Joe Perches <joe@...ches.com>
Subject: [RFC] NAPI behavior when (work < weight)

Hi

I am observing that if driver does not calls napi_complete() when
less than full budget consumed, various strange things happen.

For example, if driver going to napi_disable(), it may wait forever
in the loop:

	while (test_and_set_bit(NAPI_STATE_SCHED, &n->state))
		msleep(1);

if last NAPI consumed less then full budget, because bit
NAPI_STATE_SCHED never cleared.

Is it expected that driver calls napi_complete() when less than full
budget consumed? Documentation does not say so.

What is intended behavior in case above?

Thanks, Vladimir 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html