netdev - RE: [PATCH v3 3/3] stmmac: pci: add MSI support for Intel Quark X1000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <F54AEECA5E2B9541821D670476DAE19C2B89A551@PGSMSX102.gar.corp.intel.com>
Date:	Wed, 4 Feb 2015 03:49:01 +0000
From:	"Kweh, Hock Leong" <hock.leong.kweh@...el.com>
To:	Bryan O'Donoghue <pure.logic@...us-software.ie>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"Ahmad, Josef" <josef.ahmad@...el.com>,
	"Ong, Boon Leong" <boon.leong.ong@...el.com>
Subject: RE: [PATCH v3 3/3] stmmac: pci: add MSI support for Intel Quark
 X1000

> -----Original Message-----
> From: Bryan O'Donoghue [mailto:pure.logic@...us-software.ie]
> Sent: Monday, February 02, 2015 11:50 PM
> To: Andy Shevchenko
> Cc: netdev@...r.kernel.org; Kweh, Hock Leong; davem@...emloft.net;
> Ahmad, Josef
> Subject: Re: [PATCH v3 3/3] stmmac: pci: add MSI support for Intel Quark
> X1000
> 
> On 02/02/15 15:46, Andy Shevchenko wrote:
> > On Mon, 2015-02-02 at 15:17 +0000, Bryan O'Donoghue wrote:
> > > Hi guys.
> > >
> > > Has the issue with PVM masking been addressed ?
> > >
> > > https://lkml.org/lkml/2014/10/1/221
> > >
> > > If not then please drop MSIs from this patchset.
> >
> > I do not see the reason why it should be done on per driver basis.
> 
> Agree.
> 
> > Care to fix this under arch/x86 then when adding new Quark platform?
> 
> Looking into that now.
> 
> Hmm - OK -let's aim to get a fix in for the bridge and leave the MSI enable in
> place.
> 

I am also agreeing on that. Thanks.

Regards,
Wilson