netdev - Re: [PATCH net-next] i40e: mark constant as ULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1423072177.2589.66.camel@jtkirshe-mobl>
Date:	Wed, 04 Feb 2015 09:49:37 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Stefan Assmann <sassmann@...nic.de>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	e1000-devel@...ts.sourceforge.net
Subject: Re: [PATCH net-next] i40e: mark constant as ULL

On Wed, 2015-02-04 at 12:41 +0100, Stefan Assmann wrote:
> This avoids a compile error on 32bit.
> 
> Signed-off-by: Stefan Assmann <sassmann@...nic.de>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Come to find out, I already have a fix in my queue for this.  So I will
be dropping your patch.

The patch in my queue fixes the issue by doing the folling change:
-               mask = 0xFFFFFFFFFFFFFFFF;
+               mask = ~(u64)0;

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)