netdev - Re: [PATCH v2 01/18] netlink: make the check for "send from tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150203.162102.2178616439474613506.davem@davemloft.net>
Date:	Tue, 03 Feb 2015 16:21:02 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	sergei.shtylyov@...entembedded.com
Cc:	viro@...IV.linux.org.uk, netdev@...r.kernel.org
Subject: Re: [PATCH v2 01/18] netlink: make the check for "send from
 tx_ring" deterministic

From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Date: Mon, 02 Feb 2015 16:14:16 +0300

> On 2/2/2015 10:59 AM, Al Viro wrote:
> 
>> From: Al Viro <viro@...iv.linux.org.uk>
> 
>> + /* It's a really convoluted way for userland to ask for mmaped
>> +	 * sendmsg(), but that's what we've got...  */
> 
>    Hmm, not sure why DaveM hasn't commented on this broken comment
>    formatting (perhaps he was going to fix it while applying?). The
>    preferred comment style in the networking code is:
> 
> /* bla
>  * bla
>  */

Indeed, Al can you please audit your whole series for this issue and
respin?

Please also explicitly give me the GIT url to pull from each time you
post the series.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html