netdev - Re: [PATCH net v3] net: ipv6: allow explicitly choosing optimistic addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAedzxptQEX+c+khEmO7QvU+58+3W+iuOJ3O9zBfuWbWjFkakw@mail.gmail.com>
Date:	Wed, 4 Feb 2015 19:54:56 +0900
From:	Erik Kline <ek@...gle.com>
To:	Lorenzo Colitti <lorenzo@...gle.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Hannes Frederic Sowa <hannes@...essinduktion.org>
Subject: Re: [PATCH net v3] net: ipv6: allow explicitly choosing optimistic addresses

On Wed, Feb 4, 2015 at 7:47 PM, Lorenzo Colitti <lorenzo@...gle.com> wrote:
> On Wed, Feb 4, 2015 at 7:38 PM, Erik Kline <ek@...gle.com> wrote:
>> One more thing I just noticed, though: if the interface and the
>> address matches the supplied arguments but we don't like the flags we
>> keep on processing all other addresses on that interface I think.  Is
>> that right?  (Easy to fix in a follow on patch.)
>
> What else would the code do? It loops over all the addresses on the
> system in hash table order, not interface-by-interface.

<off_topic>
Well, I was wondering about:

        hlist_for_each_entry_rcu(...) {
                if (!net_eq(dev_net(ifp->idev->dev), net))
                        continue;
                if (!ipv6_addr_equal(&ifp->addr, addr))
                        continue;

                if (flags_testing && etc) { unlock; return 1; }
                else break;
        }

But the correctness of this depends on where else an identical IPv6
address might be assigned.  Hard for me to say without more dedicated
time to study it.
</off_topic>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html