netdev - Re: [PATCH net v4] net: ipv6: allow explicitly choosing optimistic addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKD1Yr1+49qoJC5HURKfrUDyEO7Z+LtLAq0AVb9jMofoM4WEfg@mail.gmail.com>
Date:	Wed, 4 Feb 2015 20:53:31 +0900
From:	Lorenzo Colitti <lorenzo@...gle.com>
To:	Erik Kline <ek@...gle.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Hannes Frederic Sowa <hannes@...essinduktion.org>
Subject: Re: [PATCH net v4] net: ipv6: allow explicitly choosing optimistic addresses

On Wed, Feb 4, 2015 at 8:01 PM, Erik Kline <ek@...gle.com> wrote:
> +               /* Decouple optimistic from tentative for evaluation here.
> +                * Ban optimistic addresses explicitly, when required.
> +                */

I don't find this comment particularly useful, but I suppose there's
no harm in having it.

> +               ifp_flags = (ifp->flags&IFA_F_OPTIMISTIC)
> +                           ? (ifp->flags&~IFA_F_TENTATIVE)
> +                           : ifp->flags;
>                 if (ipv6_addr_equal(&ifp->addr, addr) &&
> -                   !(ifp->flags&IFA_F_TENTATIVE) &&
> +                   !(ifp_flags&banned_flags) &&
>                     (dev == NULL || ifp->idev->dev == dev ||

That looks correct now. It's also nicer than what I had proposed.

Adding the new ipv6_chk_addr_and_flags function is definitely less
churn than the alternative of updating all the callers of
ipv6_chk_addr (19 files) to pass in the extra argument. Not sure which
is preferred, the churn or the new function.

Acked-by: Lorenzo Colitti <lorenzo@...gle.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html