netdev - [PATCH] net: core/dev: fix sparse warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1423052746-3688-1-git-send-email-prabhakar.csengg@gmail.com>
Date:	Wed,  4 Feb 2015 12:25:46 +0000
From:	Lad Prabhakar <prabhakar.csengg@...il.com>
To:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
	"Lad, Prabhakar" <prabhakar.csengg@...il.com>
Subject: [PATCH] net: core/dev: fix sparse warning

From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>

this patch fixes following sparse warning:
net/core/dev.c: In function 'validate_xmit_skb_list':
net/core/dev.c:2720: warning: 'tail' may be used uninitialized in this function

Although its a false positive, as head is assigned to NULL in the
beginning, due which later in the loop tail is assigned to skb->prev.

Signed-off-by: Lad, Prabhakar <prabhakar.csengg@...il.com>
---
 net/core/dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index 8ce0d1a..c736467 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2717,7 +2717,7 @@ out_null:
 
 struct sk_buff *validate_xmit_skb_list(struct sk_buff *skb, struct net_device *dev)
 {
-	struct sk_buff *next, *head = NULL, *tail;
+	struct sk_buff *next, *head = NULL, *tail = NULL;
 
 	for (; skb != NULL; skb = next) {
 		next = skb->next;
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html