netdev - Re: [PATCH net] pktgen: fix UDP checksum computation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150205105216.GB24388@casper.infradead.org>
Date:	Thu, 5 Feb 2015 10:52:16 +0000
From:	Thomas Graf <tgraf@...g.ch>
To:	Sabrina Dubroca <sd@...asysnail.net>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net] pktgen: fix UDP checksum computation

On 02/04/15 at 11:08pm, Sabrina Dubroca wrote:
> This patch fixes two issues in UDP checksum computation in pktgen.
> 
> First, the pseudo-header uses the source and destination IP
> addresses. Currently, the ports are used for IPv4.
> 
> Second, the UDP checksum covers both header and data.  So we need to
> generate the data earlier (move pktgen_finalize_skb up), and compute
> the checksum for UDP header + data.
> 
> Fixes: c26bf4a51308c ("pktgen: Add UDPCSUM flag to support UDP checksums")
> Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>

Acked-by: Thomas Graf <tgraf@...g.ch>

Thanks for fixing this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html