netdev - Re: [PATCH 1/1] neighbour: Support broadcast ARP in neighbor PROPE state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 05 Feb 2015 15:12:24 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	zhuyj <zyjzyj2000@...il.com>, netdev@...r.kernel.org,
	stefan.costandache@...driver.com, alexandre.dietsch@...driver.com,
	yue.tao@...driver.com, clinton.slabbert@...driver.com
CC:	eulfsam <ulf.samuelsson@...csson.com>,
	"David S. Miller" <davem@...emloft.net>,
	WANG Cong <xiyou.wangcong@...il.com>
Subject: Re: [PATCH 1/1] neighbour: Support broadcast ARP in neighbor PROPE
 state

Hello.

On 2/5/2015 10:20 AM, zhuyj wrote:

> From: eulfsam <ulf.samuelsson@...csson.com>

> When the neighbor statemachine is in PROBE state, it will normally send

    State machine.

> a number of unicast ARP requests (number defined in "ucast_probes" entry
> in the proc file system, default=3) and if no reply is received, it will
> change state to FAILED.

> Enabling CONFIG_ARP_PROBE_BCAST, will make the statemachine try to send

    Likewise.

> broadcast ARP requests, and only enter FAILED state if the broadcast ARP
> requests did not receive a reply.

> Enabling CONFIG_ARP_PROBE_BCAST, makes the IPv4 ARP behaviour more
> similar to the IPv6 Neighbor Discovery protocol, and is neccessary,

    Necessary.

> if the other end only responds to broadcast ARPs.

> CC: David S. Miller <davem@...emloft.net>
> CC: WANG Cong <xiyou.wangcong@...il.com>
> Signed-off-by: eulfsam <ulf.samuelsson@...csson.com>
> Signed-off-by: zhuyj <zyjzyj2000@...il.com>

    Need real names here.

[...]

> diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
> index bd29016..4d13edb 100644
> --- a/net/ipv4/Kconfig
> +++ b/net/ipv4/Kconfig
> @@ -259,6 +259,23 @@ config IP_PIMSM_V2
>   	  gated-5). This routing protocol is not used widely, so say N unless
>   	  you want to play with it.
>
> +config ARP_PROBE_BCAST
> +	bool "IP: ARP send broadcast ARP, if probing using unicast fails"
> +	default	y
> +	---help---
> +	  When the neighbor statemachine is in PROBE state, it will

    State machine.

> +	  normally send a number of unicast ARP requests
> +	  (number defined in "ucast_probes" entry in the proc file system, default=3)
> +	  and if no reply is received, it will change state to FAILED.
> +
> +	  Saying Y here, will make the statemachine try to send broadcast ARP

    Likewise.

> +	  requests, and only enter FAILED state if the broadcast ARP requests did not
> +	  receive a reply.
> +
> +	  Enabling this, makes the IPv4 ARP behaviour more similar to the IPv6
> +	  Neighbor Discovery protocol, and is neccessary, if the other end

    Necessary.

[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html