netdev - Re: [PATCH] xen-netback: fix sparse warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150205140112.GC4311@zion.uk.xensource.com>
Date:	Thu, 5 Feb 2015 14:01:12 +0000
From:	Wei Liu <wei.liu2@...rix.com>
To:	Lad Prabhakar <prabhakar.csengg@...il.com>
CC:	Ian Campbell <ian.campbell@...rix.com>,
	Wei Liu <wei.liu2@...rix.com>,
	<xen-devel@...ts.xenproject.org>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] xen-netback: fix sparse warning

On Thu, Feb 05, 2015 at 01:38:07PM +0000, Lad Prabhakar wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
> 
> this patch fixes following sparse warning:
> 
> interface.c:83:5: warning: symbol 'xenvif_poll' was not declared. Should it be static?
> 
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@...il.com>

Acked-by: Wei Liu <wei.liu2@...rix.com>

Thanks!

> ---
>  Found this issue on linux-next (gcc  version 4.9.2,
>  sparse version  0.4.5-rc1)and applies on top linux-next.
> 
>  drivers/net/xen-netback/interface.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
> index 12f9e27..f38227a 100644
> --- a/drivers/net/xen-netback/interface.c
> +++ b/drivers/net/xen-netback/interface.c
> @@ -80,7 +80,7 @@ static irqreturn_t xenvif_tx_interrupt(int irq, void *dev_id)
>  	return IRQ_HANDLED;
>  }
>  
> -int xenvif_poll(struct napi_struct *napi, int budget)
> +static int xenvif_poll(struct napi_struct *napi, int budget)
>  {
>  	struct xenvif_queue *queue =
>  		container_of(napi, struct xenvif_queue, napi);
> -- 
> 1.9.1
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html