netdev - Re: [PATCH 1/2] ipv6: Resolve sparce error with fragment id selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1423148276.31870.69.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 05 Feb 2015 06:57:56 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Vladislav Yasevich <vyasevich@...il.com>
Cc:	netdev@...r.kernel.org, Vladislav Yasevich <vyasevic@...hat.com>
Subject: Re: [PATCH 1/2] ipv6: Resolve sparce error with fragment id
 selection

On Thu, 2015-02-05 at 09:41 -0500, Vladislav Yasevich wrote:
> Resolve the following sparce error:
>  net/ipv6/output_core.c:57:38: sparse: incorrect type in assignment
>  (different base types)
>    net/ipv6/output_core.c:57:38:    expected restricted __be32
> [usertype] ip6_frag_id
>    net/ipv6/output_core.c:57:38:    got unsigned int [unsigned]
> [assigned] [usertype] id
> 

patch title is misleading.

Lot of 'sparse bugs' are about not using proper types, but here
a bug on little endian arches is fixed.

sparse helped to detect the bug.

> Fixes: 0508c07f5e0c9 (ipv6: Select fragment id during UFO segmentation
> if not set.)

Please do not wrap this line

> Signed-off-by: Vladislav Yasevich <vyasevic@...hat.com>
> ---
>  net/ipv6/output_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ipv6/output_core.c b/net/ipv6/output_core.c
> index 54520a0..a86cf60 100644
> --- a/net/ipv6/output_core.c
> +++ b/net/ipv6/output_core.c
> @@ -54,7 +54,7 @@ void ipv6_proxy_select_ident(struct sk_buff *skb)
>  
>  	id = __ipv6_select_ident(ip6_proxy_idents_hashrnd,
>  				 &addrs[1], &addrs[0]);
> -	skb_shinfo(skb)->ip6_frag_id = id;
> +	skb_shinfo(skb)->ip6_frag_id = htonl(id);
>  }
>  EXPORT_SYMBOL_GPL(ipv6_proxy_select_ident);
>  


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html