netdev - Re: [PATCH net-next 2/3] IB/mlx4: Always use the correct port for mirrored multicast attachments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 5 Feb 2015 17:18:06 +0200
From:	Moni Shoua <monis@...lanox.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	Or Gerlitz <ogerlitz@...lanox.com>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	Roland Dreier <roland@...nel.org>,
	Amir Vadai <amirv@...lanox.com>, Tal Alon <talal@...lanox.com>
Subject: Re: [PATCH net-next 2/3] IB/mlx4: Always use the correct port for
 mirrored multicast attachments

>>                         goto err_create_flow;
>>                 i++;
>>                 if (is_bonded) {
>> +                       /* Application always sees one port so the mirror
>> rule
>> +                        * must be on port #2
>> +                        */
>
>
>    Unrelated change?
>
I think that it is somewhat related since it explains why the fix,
though seems to be relevant also here is actually not
>>                         flow_attr->port = 2;
>>                         err = __mlx4_ib_create_flow(qp, flow_attr,
>>                                                     domain, type[j],
>> @@ -1279,14 +1282,15 @@ static int mlx4_ib_mcg_attach(struct ib_qp *ibqp,
>> union ib_gid *gid, u16 lid)
>>
>>         err = mlx4_multicast_attach(mdev->dev, &mqp->mqp, gid->raw,
>> mqp->port,
>>                                     !!(mqp->flags &
>> -
>> MLX4_IB_QP_BLOCK_MULTICAST_LOOPBACK),
>> +                                   MLX4_IB_QP_BLOCK_MULTICAST_LOOPBACK),
>
>
>    This change is both unrelated and unneeded.
I agree.
>
>>                                     prot, &reg_id.id);
>>         if (err)
>>                 goto err_malloc;
>>
>>         reg_id.mirror = 0;
>>         if (mlx4_is_bonded(dev)) {
>> -               err = mlx4_multicast_attach(mdev->dev, &mqp->mqp,
>> gid->raw, 2,
>> +               err = mlx4_multicast_attach(mdev->dev, &mqp->mqp,
>> gid->raw,
>> +                                           (mqp->port == 1) ? 2 : 1,
>
>
>    I doubt that these parens are needed.
You are right if all you care about is the machine code. For
readability I like the parens.
>
> WBR, Sergei
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html