netdev - Re: [PATCH iproute2] ss: group DCTCP socket statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150205104423.18b0b59b@urahara>
Date:	Thu, 5 Feb 2015 10:44:23 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Hagen Paul Pfeifer <hagen@...u.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH iproute2] ss: group DCTCP socket statistics

On Mon, 26 Jan 2015 23:17:39 +0100
Hagen Paul Pfeifer <hagen@...u.net> wrote:

> Keep ss output consistent and format DCTCP socket statistics similar to skmen
> and timer where a group of logical values are grouped by brackets. This makes
> parser scripts *and* humans more happy.
> 
> 
> Current output of 'ss -inetm dst :80':
> ESTAB       0      0 192.168.11.14:55511 173.194.66.189:443
> 	timer:(keepalive,14sec,0) uid:1000 ino:428768
> 	sk:ffff88020ceb5b00 <-> skmem:(r0,rb372480,t0,tb87040,f0,w0,o0,bl0)
> 	ts sack wscale:7,7 rto:250 rtt:49.225/20.837 ato:40 mss:1408 cwnd:10
> 	ce_state 23 alpha 23 ab_ecn 23 ab_tot 23 send 2.3Mbps
> 	lastsnd:121026 lastrcv:121026 lastack:30850 pacing_rate 4.6Mbps
> 	retrans:0/2 rcv_rtt:40.416 rcv_space:2920
> 
> New grouped output:
> ESTAB       0      0 192.168.11.14:55511 173.194.66.189:443
> 	timer:(keepalive,14sec,0) uid:1000 ino:428768
> 	sk:ffff88020ceb5b00 <-> skmem:(r0,rb372480,t0,tb87040,f0,w0,o0,bl0)
> 	ts sack wscale:7,7 rto:250 rtt:49.225/20.837 ato:40 mss:1408 cwnd:10
> 	dctcp(ce_state:23,alpha:23,ab_ecn:23,ab_tot:23) send 2.3Mbps
> 	lastsnd:121026 lastrcv:121026 lastack:30850 pacing_rate 4.6Mbps
> 	retrans:0/2 rcv_rtt:40.416 rcv_space:2920
> 
> Cc: Stephen Hemminger <stephen@...workplumber.org>
> Acked-by: Daniel Borkmann <dborkman@...hat.com>
> Acked-by: Florian Westphal <fw@...len.de>
> Signed-off-by: Hagen Paul Pfeifer <hagen@...u.net>
> ---
>  misc/ss.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

The patch looks fine, although changing output formats is normally not good
because someone might be scripting from this. But DCTCP is so new I am
willing to allow the change.

The problem is that the patch does not apply to either the master
(or net-next) branchs of upstream source.

Please fix that and resubmit.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html