lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 06 Feb 2015 12:50:27 -0800 (PST) From: David Miller <davem@...emloft.net> To: dan.carpenter@...cle.com Cc: bh74.an@...sung.com, kgene@...nel.org, ks.giri@...sung.com, vipul.pandya@...sung.com, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [patch] net: sxgbe: fix error handling in init_rx_ring() From: Dan Carpenter <dan.carpenter@...cle.com> Date: Thu, 5 Feb 2015 11:00:42 +0300 > There are a couple bugs with the error handling in this function. > > 1) If we can't allocate "rx_ring->rx_skbuff" then we should call > dma_free_coherent() but we don't. > 2) free_rx_ring() frees "rx_ring->rx_skbuff_dma" and "rx_ring->rx_skbuff" > so calling it in a loop causes a double free. > > Also it was a bit confusing how we sometimes freed things before doing > the goto. I've cleaned it up so it does error handling in normal kernel > style. > > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com> Looks good, applied, thanks Dan. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists