netdev - Re: [PATCH net] pktgen: fix UDP checksum computation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1423182482.31870.99.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 05 Feb 2015 16:28:02 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Tom Herbert <therbert@...gle.com>
Cc:	Sabrina Dubroca <sd@...asysnail.net>,
	David Miller <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>,
	Thomas Graf <tgraf@...g.ch>
Subject: Re: [PATCH net] pktgen: fix UDP checksum computation

On Thu, 2015-02-05 at 15:57 -0800, Tom Herbert wrote:

> Would it be possible to use udp_set_csum to handle all of this?

This reminds me we have following sparse errors with checksum code,
could you take a look Tom ?

make C=2 CF=-D__CHECK_ENDIAN__  ...

include/linux/skbuff.h:3022:24: warning: incorrect type in return expression (different base types)
include/linux/skbuff.h:3022:24:    expected restricted __sum16
include/linux/skbuff.h:3022:24:    got int

net/ipv6/ip6_checksum.c:83:16: warning: incorrect type in return expression (different base types)
net/ipv6/ip6_checksum.c:83:16:    expected int
net/ipv6/ip6_checksum.c:83:16:    got restricted __sum16 [assigned] [usertype] __ret

  CHECK   net/ipv4/tcp_offload.c
net/ipv4/tcp_offload.c:139:60: warning: incorrect type in argument 2 (different base types)
net/ipv4/tcp_offload.c:139:60:    expected restricted __wsum [usertype] res
net/ipv4/tcp_offload.c:139:60:    got fouled restricted __sum16
include/linux/skbuff.h:3317:14: warning: incorrect type in assignment (different base types)
include/linux/skbuff.h:3317:14:    expected unsigned short [unsigned] [usertype] csum
include/linux/skbuff.h:3317:14:    got restricted __sum16
include/linux/skbuff.h:3322:16: warning: incorrect type in return expression (different base types)
include/linux/skbuff.h:3322:16:    expected restricted __sum16
include/linux/skbuff.h:3322:16:    got unsigned short [unsigned] [usertype] csum
net/ipv4/tcp_offload.c:173:52: warning: incorrect type in argument 2 (different base types)
net/ipv4/tcp_offload.c:173:52:    expected restricted __wsum [usertype] res
net/ipv4/tcp_offload.c:173:52:    got fouled restricted __sum16
include/linux/skbuff.h:3317:14: warning: incorrect type in assignment (different base types)
include/linux/skbuff.h:3317:14:    expected unsigned short [unsigned] [usertype] csum
include/linux/skbuff.h:3317:14:    got restricted __sum16
include/linux/skbuff.h:3322:16: warning: incorrect type in return expression (different base types)
include/linux/skbuff.h:3322:16:    expected restricted __sum16
include/linux/skbuff.h:3322:16:    got unsigned short [unsigned] [usertype] csum


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html