netdev - Re: [RFC PATCH 19/29] net: vrf: Add vrf context to skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878ugbwv7t.fsf@x220.int.ebiederm.org>
Date:	Thu, 05 Feb 2015 21:54:30 -0600
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	David Ahern <dsahern@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [RFC PATCH 19/29] net: vrf: Add vrf context to skb

David Ahern <dsahern@...il.com> writes:

> On ingress skb's inherit vrf context from the net_device. For TX skb's
> inherit the vrf context from the socket originating the packet. Update
> SKB related net_ctx macros to set vrf.

Nacked-by: "Eric W. Biederman" <ebiederm@...ssion.com>

As I recall we had the conversation about modifying  struct sk_buff when
implementing network namespaces and it turns out it is a no go.  It adds
too much overhead.  As I recall skbs as they are on the fastpath are
things we want to make smaller.

> Signed-off-by: David Ahern <dsahern@...il.com>
> ---
>  include/linux/skbuff.h   |  7 ++++---
>  include/net/sock.h       |  2 ++
>  include/net/tcp.h        |  1 +
>  net/core/dev.c           |  1 +
>  net/core/fib_rules.c     |  2 ++
>  net/core/neighbour.c     |  2 ++
>  net/core/skbuff.c        | 12 ++++++++++++
>  net/ipv4/devinet.c       |  2 ++
>  net/ipv4/icmp.c          |  2 +-
>  net/ipv4/ip_output.c     |  2 ++
>  net/ipv4/syncookies.c    |  1 +
>  net/ipv4/tcp_ipv4.c      |  3 ++-
>  net/netlink/af_netlink.c | 12 ++++++++++++
>  13 files changed, 44 insertions(+), 5 deletions(-)
>
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index a5dfef469d07..bdbee41e8032 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -522,6 +522,7 @@ struct sk_buff {
>  	};
>  	struct sock		*sk;
>  	struct net_device	*dev;
> +	__u32			vrf;
>  
>  	/*
>  	 * This is the control buffer. It is free to use for every
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html