netdev - Re: [PATCH v2 1/3] bridge: Base the BR_PROXYARP decision on the target port flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150207.215922.1914777712701024499.davem@davemloft.net>
Date:	Sat, 07 Feb 2015 21:59:22 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jouni@...eaurora.org
Cc:	netdev@...r.kernel.org, kyeyoonp@...eaurora.org
Subject: Re: [PATCH v2 1/3] bridge: Base the BR_PROXYARP decision on the
 target port flag

From: Jouni Malinen <jouni@...eaurora.org>
Date: Thu,  5 Feb 2015 11:54:21 +0200

> From: Kyeyoon Park <kyeyoonp@...eaurora.org>
> 
> When doing proxy ARP, instead of checking the bridge port flag for
> BR_PROXYARP on the bridge port on which the frame was received, check
> the bridge port flag of the bridge port to which the target device
> belongs.
> 
> Signed-off-by: Kyeyoon Park <kyeyoonp@...eaurora.org>
> Signed-off-by: Jouni Malinen <jouni@...eaurora.org>
> ---
> v2: Address Stephen's comment on mixing && and & without parens
>     and check for f->dst != NULL before dereferencing it

This is a semantic change, what if the administrator wanted the
current behavior?

I'm not applying this.  If you want the new behavior, it will have
to be at a minimum turned on via a sysctl that defaults to OFF.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html