netdev - Re: [E1000-devel] [PATCH] net:ethernet:intel:Remove outdated fix me comment in the function, gb_acquire_swfw_sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1423445359.2589.171.camel@jtkirshe-mobl>
Date:	Sun, 08 Feb 2015 17:29:19 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	nick <xerofoify@...il.com>
Cc:	linux.nics@...el.com, e1000-devel@...ts.sourceforge.net,
	bruce.w.allan@...el.com, jesse.brandeburg@...el.com,
	linux-kernel@...r.kernel.org, john.ronciak@...el.com,
	netdev@...r.kernel.org
Subject: Re: [E1000-devel] [PATCH] net:ethernet:intel:Remove outdated fix me
 comment in the function, gb_acquire_swfw_sync_i210

On Sun, 2015-02-08 at 20:28 -0500, nick wrote:
> 
> On 2015-02-08 08:26 PM, Jeff Kirsher wrote:
> > On Sun, 2015-02-08 at 17:21 -0800, Jeff Kirsher wrote:
> >> On Sun, 2015-02-08 at 00:21 -0500, Nicholas Krause wrote:
> >>> Removes the outdated fix me comment in the
> >>> function,gb_acquire_swfw_sync_i210
> >>> for setting the variables, i and timeout to the intended correct
> >>> values for
> >>> the function,gb_acquire_swfw_sync_i210 to function correctly. This
> >>> comment is
> >>> no longer due to these values having been no changed in the last few
> >>> years and
> >>> no known issues have been found for these variables being set to their
> >>> current
> >>> values. Due to this the comment can now be removed as the values set
> >>> for these
> >>> variables are known to be correct after years of no known issues or
> >>> bugs related
> >>> to their current values.
> >>>
> >>> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> >>> ---
> >>>  drivers/net/ethernet/intel/igb/e1000_i210.c | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> Thank Nick, I will add your patch to my queue.
> > 
> > Oh and the title should be "igb: Remove outdated ...", not
> > "net:ethernet:intel: Remove ..."
> > 
> Jeff,
> Sorry about the title. Good to known for next time. Should I resend or 
> will you fix the title for me?
> Cheers,
> Nick

I will fix the title.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)