netdev - RE: [net-next 15/15] i40e/i40evf: Add call to u64_stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 9 Feb 2015 16:45:43 +0000
From:	"Wyborny, Carolyn" <carolyn.wyborny@...el.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"davem@...emloft.net" <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"nhorman@...hat.com" <nhorman@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>,
	"jogreene@...hat.com" <jogreene@...hat.com>
Subject: RE: [net-next 15/15] i40e/i40evf: Add call to u64_stats_init to init

> -----Original Message-----
> From: Sergei Shtylyov [mailto:sergei.shtylyov@...entembedded.com]
> Sent: Monday, February 09, 2015 4:09 AM
> To: Kirsher, Jeffrey T; davem@...emloft.net
> Cc: Wyborny, Carolyn; netdev@...r.kernel.org; nhorman@...hat.com;
> sassmann@...hat.com; jogreene@...hat.com
> Subject: Re: [net-next 15/15] i40e/i40evf: Add call to u64_stats_init to init
> 
> Hello.
> 
[..]
> > +		u64_stats_init(rx_ring->syncp);
> 
>     This is over-indented.
> 
> > +
> >   	/* Round up to nearest 4K */
> >   	rx_ring->size = ring_is_16byte_desc_enabled(rx_ring)
> >   		? rx_ring->count * sizeof(union i40e_16byte_rx_desc) diff --git
> > a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c
> > b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c
> > index 4bf15da..459499a 100644
> > --- a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c
> > +++ b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c
> > @@ -596,6 +596,8 @@ int i40evf_setup_rx_descriptors(struct i40e_ring
> *rx_ring)
> >   	if (!rx_ring->rx_bi)
> >   		goto err;
> >
> > +		u64_stats_init(rx_ring->syncp);
> 
>     Likewise.
> 
> > +
> >   	/* Round up to nearest 4K */
> >   	rx_ring->size = ring_is_16byte_desc_enabled(rx_ring)
> >   		? rx_ring->count * sizeof(union i40e_16byte_rx_desc)
> 
> WBR, Sergei
Thanks, I have already submitted a patch to correct this, but need to track down the same change in the vf code.  

Jeff, do you know how close it is to submission?  

Carolyn

Carolyn Wyborny 
Linux Development 
Networking Division 
Intel Corporation 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html