netdev - Re: [PATCH] net: dsa: Remove redundant phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150209.140605.383021111937070414.davem@redhat.com>
Date:	Mon, 09 Feb 2015 14:06:05 -0800 (PST)
From:	David Miller <davem@...hat.com>
To:	f.fainelli@...il.com
Cc:	andrew@...n.ch, netdev@...r.kernel.org
Subject: Re: [PATCH] net: dsa: Remove redundant phy_attach()

From: Florian Fainelli <f.fainelli@...il.com>
Date: Mon, 09 Feb 2015 11:21:26 -0800

> On 08/02/15 17:29, Andrew Lunn wrote:
>> dsa_slave_phy_setup() finds the phy for the port via device tree and
>> using of_phy_connect(), or it uses the fall back of taking a phy from
>> the switch internal mdio bus and calling phy_connect_direct(). Either
>> way, if a phy is found, phy_attach_direct() is called to attach the
>> phy to the slave device.
>> 
>> In dsa_slave_create(), a second call to phy_attach() is made. This
>> results in the warning "PHY already attached". Remove this second,
>> redundant attaching of the phy.
>> 
>> Signed-off-by: Andrew Lunn <andrew@...n.ch>
> 
> Acked-by: Florian Fainelli <f.fainelli@...il.com>
> Tested-by: Florian Fainelli <f.fainelli@...il.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html