netdev - Re: [PATCH net] bridge: Fix inability to add non-vlan fdb entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150209.141921.609350329551731658.davem@redhat.com>
Date:	Mon, 09 Feb 2015 14:19:21 -0800 (PST)
From:	David Miller <davem@...hat.com>
To:	makita.toshiaki@....ntt.co.jp
Cc:	stephen@...workplumber.org, vyasevic@...hat.com,
	bridge@...ts.linux-foundation.org, netdev@...r.kernel.org
Subject: Re: [PATCH net] bridge: Fix inability to add non-vlan fdb entry

From: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
Date: Mon,  9 Feb 2015 20:16:17 +0900

> Bridge's default_pvid adds a vid by default, by which we cannot add a
> non-vlan fdb entry by default, because br_fdb_add() adds fdb entries for
> all vlans instead of a non-vlan one when any vlan is configured.
> 
>  # ip link add br0 type bridge
>  # ip link set eth0 master br0
>  # bridge fdb add 12:34:56:78:90:ab dev eth0 master temp
>  # bridge fdb show brport eth0 | grep 12:34:56:78:90:ab
>  12:34:56:78:90:ab dev eth0 vlan 1 static
> 
> We expect a non-vlan fdb entry as well as vlan 1:
>  12:34:56:78:90:ab dev eth0 static
> 
> To fix this, we need to insert a non-vlan fdb entry if vlan is not
> specified, even when any vlan is configured.
> 
> Fixes: 5be5a2df40f0 ("bridge: Add filtering support for default_pvid")
> Signed-off-by: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html