lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <54D85EFA.3020501@gmail.com> Date: Mon, 09 Feb 2015 02:17:14 -0500 From: Andrej Manduch <amanduch@...il.com> To: Jeff Kirsher <jeffrey.t.kirsher@...el.com>, Nicholas Krause <xerofoify@...il.com> CC: jesse.brandeburg@...el.com, bruce.w.allan@...el.com, carolyn.wyborny@...el.com, donald.c.skidmore@...el.com, gregory.v.rose@...el.com, matthew.vick@...el.com, john.ronciak@...el.com, mitch.a.williams@...el.com, linux.nics@...el.com, e1000-devel@...ts.sourceforge.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] net:ethernet:intel:Remove outdated fix me comment in the function,gb_acquire_swfw_sync_i210 Hi, Can you please leave full patch with git diff when you're replying to Nicks e-mails? Nick is banned in *@...r.kernel.org so we cannot see his patches and rest of the world is seeing only replyies to his e-mail. And it's really hard to test anything when we don't see changes. On 02/08/2015 08:21 PM, Jeff Kirsher wrote: > On Sun, 2015-02-08 at 00:21 -0500, Nicholas Krause wrote: >> Removes the outdated fix me comment in the >> function,gb_acquire_swfw_sync_i210 >> for setting the variables, i and timeout to the intended correct >> values for >> the function,gb_acquire_swfw_sync_i210 to function correctly. This >> comment is >> no longer due to these values having been no changed in the last few >> years and >> no known issues have been found for these variables being set to their >> current >> values. Due to this the comment can now be removed as the values set >> for these >> variables are known to be correct after years of no known issues or >> bugs related >> to their current values. >> >> Signed-off-by: Nicholas Krause <xerofoify@...il.com> >> --- >> drivers/net/ethernet/intel/igb/e1000_i210.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Thank Nick, I will add your patch to my queue. > -- Kind regards, b. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists