netdev - Re: [PATCH net-next] net: silence sparse endianness warnings in checksums

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150208.163001.1517021094146035035.davem@davemloft.net>
Date:	Sun, 08 Feb 2015 16:30:01 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	sd@...asysnail.net
Cc:	netdev@...r.kernel.org, eric.dumazet@...il.com, therbert@...gle.com
Subject: Re: [PATCH net-next] net: silence sparse endianness warnings in
 checksums

From: Sabrina Dubroca <sd@...asysnail.net>
Date: Fri,  6 Feb 2015 15:43:52 +0100

> In __skb_checksum_validate_complete and its callers, we only test that
> the return value is non-zero, so it's safe to __force the type.
> 
> Callers of gso_make_checksum pass a __sum16, use that.
> 
> Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>

I don't like this, you're just moving the casts from one place to
another.

These functions are a mess, they are combining one thing (returning
the final csum value) with another thing (non-zero return has some
boolean meaning).

These issues should be explicitly accomodated rather than papered
around.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html