netdev - Re: [PATCH] rtlwifi: ratelimit skb allocation failure message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 10 Feb 2015 13:52:23 +0000
From:	Colin Ian King <colin.king@...onical.com>
To:	Kalle Valo <kvalo@...eaurora.org>,
	Eric Dumazet <eric.dumazet@...il.com>
CC:	Larry Finger <Larry.Finger@...inger.net>,
	Chaoming Li <chaoming_li@...lsil.com.cn>,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtlwifi: ratelimit skb allocation failure message

On 10/02/15 13:48, Kalle Valo wrote:
> Eric Dumazet <eric.dumazet@...il.com> writes:
> 
>> On Tue, 2015-02-10 at 08:54 +0000, Colin King wrote:
>>> From: Colin Ian King <colin.king@...onical.com>
>>>
>>> when running low on memory I noticed rtlwifi was producing a large
>>> quantity of repeated skb allocation failures messages.  This should
>>> be ratelimited to reduce the noise.
>>>
>>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
>>> ---
>>>  drivers/net/wireless/rtlwifi/pci.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
>>> index c70efb9..ca0fd50 100644
>>> --- a/drivers/net/wireless/rtlwifi/pci.c
>>> +++ b/drivers/net/wireless/rtlwifi/pci.c
>>> @@ -817,7 +817,7 @@ static void _rtl_pci_rx_interrupt(struct ieee80211_hw *hw)
>>>  		/* get a new skb - if fail, old one will be reused */
>>>  		new_skb = dev_alloc_skb(rtlpci->rxbuffersize);
>>>  		if (unlikely(!new_skb)) {
>>> -			pr_err("Allocation of new skb failed in %s\n",
>>> +			pr_err_ratelimited("Allocation of new skb failed in %s\n",
>>>  			       __func__);
>>
>> Or even better, remove the message.
> 
> There's actually a pending patch for that, I'll send it to Dave ASAP:
> 
> https://patchwork.kernel.org/patch/5671121/
> 
Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html