lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Feb 2015 11:37:38 +1030 From: Rusty Russell <rusty@...tcorp.com.au> To: Jason Wang <jasowang@...hat.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, virtualization@...ts.linux-foundation.org, mst@...hat.com Cc: pagupta@...hat.com Subject: Re: [PATCH RFC v5 net-next 2/6] virtio_ring: try to disable event index callbacks in virtqueue_disable_cb() Jason Wang <jasowang@...hat.com> writes: > Currently, we do nothing to prevent the callbacks in > virtqueue_disable_cb() when event index is used. This may cause > spurious interrupts which may damage the performance. This patch tries > to publish avail event as the used even to prevent the callbacks. > > Signed-off-by: Jason Wang <jasowang@...hat.com> Acked-by: Rusty Russell <rusty@...tcorp.com.au> > --- > drivers/virtio/virtio_ring.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > index 545fed5..e9ffbfb 100644 > --- a/drivers/virtio/virtio_ring.c > +++ b/drivers/virtio/virtio_ring.c > @@ -539,6 +539,8 @@ void virtqueue_disable_cb(struct virtqueue *_vq) > struct vring_virtqueue *vq = to_vvq(_vq); > > vq->vring.avail->flags |= cpu_to_virtio16(_vq->vdev, VRING_AVAIL_F_NO_INTERRUPT); > + vring_used_event(&vq->vring) = cpu_to_virtio16(_vq->vdev, > + vq->vring.avail->idx); > } > EXPORT_SYMBOL_GPL(virtqueue_disable_cb); > > -- > 1.8.3.1 > > _______________________________________________ > Virtualization mailing list > Virtualization@...ts.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/virtualization -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists