netdev - Re: [PATCH] ipv6: Partial checksum only UDP packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150210162312.GB3372@kria>
Date:	Tue, 10 Feb 2015 17:23:12 +0100
From:	Sabrina Dubroca <sd@...asysnail.net>
To:	Vladislav Yasevich <vyasevich@...il.com>
Cc:	netdev@...r.kernel.org, Vladislav Yasevich <vyasevic@...hat.com>
Subject: Re: [PATCH] ipv6: Partial checksum only UDP packets

2015-02-10, 10:55:52 -0500, Vladislav Yasevich wrote:
> ip6_append_data is used by other protocols and some of them can't
> be partially checksummed.  Only partially checksum UDP protocol.
> 
> Fixes: 32dce968dd987a (ipv6: Allow for partial checksums on non-ufo packets)
> Reported-by: Sabrian Dubroca <sd@...asysnail.net>

not a big deal, but since there's a small problem with this version
(see below):

s/Sabrian/Sabrina/

> Signed-off-by: Vladislav Yasevich <vyasevic@...hat.com>
> ---
> Hi Sabrina
> 
> Can you try this patch.  Thanks.
> 
>  net/ipv6/ip6_output.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c
> index d33df4c..8f2d558 100644
> --- a/net/ipv6/ip6_output.c
> +++ b/net/ipv6/ip6_output.c
> @@ -1273,7 +1273,7 @@ emsgsize:
>  	/* If this is the first and only packet and device
>  	 * supports checksum offloading, let's use it.
>  	 */
> -	if (!skb &&
> +	if (!skb && sk->protocol == IPPROTO_UDP &&
                        ^^^

should be  sk->sk_protocol


And you can add:

Tested-by: Sabrina Dubroca <sd@...asysnail.net>


Thanks Vlad!

>  	    length + fragheaderlen < mtu &&
>  	    rt->dst.dev->features & NETIF_F_V6_CSUM &&
>  	    !exthdrlen)
> -- 
> 1.9.3


-- 
Sabrina
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html