netdev - Re: [PATCHv2] rds: rds_cong_queue_updates needs to defer the congestion update transmission

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150211.143610.1232446952245428061.davem@davemloft.net>
Date:	Wed, 11 Feb 2015 14:36:10 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	sowmini.varadhan@...cle.com
Cc:	chien.yen@...cle.com, rds-devel@....oracle.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2] rds: rds_cong_queue_updates needs to defer the
 congestion update transmission

From: Sowmini Varadhan <sowmini.varadhan@...cle.com>
Date: Tue, 10 Feb 2015 13:33:37 -0500

> 
> When the RDS transport is TCP, we cannot inline the call to rds_send_xmit
> from rds_cong_queue_update because
> (a) we are already holding the sock_lock in the recv path, and
>     will deadlock when tcp_setsockopt/tcp_sendmsg try to get the sock
>     lock
> (b) cong_queue_update does an irqsave on the rds_cong_lock, and this
>     will trigger warnings (for a good reason) from functions called
>     out of sock_lock.
> 
> This patch reverts the change introduced by
> 2fa57129d ("RDS: Bypass workqueue when queueing cong updates").
> 
> The patch has been verified for both RDS/TCP as well as RDS/RDMA
> to ensure that there are not regressions for either transport:
>  - for verification of  RDS/TCP a client-server unit-test was used,
>    with the server blocked in gdb and thus unable to drain its rcvbuf,
>    eventually triggering a RDS congestion update.
>  - for RDS/RDMA, the standard IB regression tests were used
> 
> 
> Signed-off-by: Sowmini Varadhan <sowmini.varadhan@...cle.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html