lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150211144016.GB3919@salvia> Date: Wed, 11 Feb 2015 15:40:16 +0100 From: Pablo Neira Ayuso <pablo@...filter.org> To: Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu> Cc: kbuild-all@...org, kbuild test robot <fengguang.wu@...el.com>, Patrick McHardy <kaber@...sh.net>, netfilter-devel@...r.kernel.org, coreteam@...filter.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] netfilter: ipset: fix boolreturn.cocci warnings On Wed, Feb 11, 2015 at 08:33:05PM +0800, kbuild test robot wrote: > net/netfilter/xt_set.c:196:9-10: WARNING: return of 0/1 in function 'set_match_v3' with return type bool > net/netfilter/xt_set.c:242:9-10: WARNING: return of 0/1 in function 'set_match_v4' with return type bool > > Return statements in functions returning bool should use > true/false instead of 1/0. > Generated by: scripts/coccinelle/misc/boolreturn.cocci Jozsef, unless you have any objection, I'm going to apply this. Thanks. > CC: Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu> > Signed-off-by: Fengguang Wu <fengguang.wu@...el.com> > --- > > xt_set.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- a/net/netfilter/xt_set.c > +++ b/net/netfilter/xt_set.c > @@ -193,7 +193,7 @@ set_match_v3(const struct sk_buff *skb, > return ret; > > if (!match_counter0(opt.ext.packets, &info->packets)) > - return 0; > + return false; > return match_counter0(opt.ext.bytes, &info->bytes); > } > > @@ -239,7 +239,7 @@ set_match_v4(const struct sk_buff *skb, > return ret; > > if (!match_counter(opt.ext.packets, &info->packets)) > - return 0; > + return false; > return match_counter(opt.ext.bytes, &info->bytes); > } > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists