netdev - Re: [PATCH net] tg3: Hold tp->lock before calling tg3_halt() from tg3_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150211.195144.1566555083391993799.davem@davemloft.net>
Date:	Wed, 11 Feb 2015 19:51:44 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	j-nomura@...jp.nec.com
Cc:	prashant@...adcom.com, mchan@...adcom.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] tg3: Hold tp->lock before calling tg3_halt() from
 tg3_init_one()

From: Junichi Nomura <j-nomura@...jp.nec.com>
Date: Thu, 12 Feb 2015 01:26:24 +0000

> tg3_init_one() calls tg3_halt() without tp->lock despite its assumption
> and causes deadlock.
> If lockdep is enabled, a warning like this shows up before the stall:
> 
>   [ BUG: bad unlock balance detected! ]
>   3.19.0test #3 Tainted: G            E
>   -------------------------------------
>   insmod/369 is trying to release lock (&(&tp->lock)->rlock) at:
>   [<ffffffffa02d5a1d>] tg3_chip_reset+0x14d/0x780 [tg3]
>   but there are no more locks to release!
> 
> tg3_init_one() doesn't call tg3_halt() under normal situation but
> during kexec kdump I hit this problem.
> 
> Fixes: 932f19de ("tg3: Release tp->lock before invoking synchronize_irq()")
> Signed-off-by: Jun'ichi Nomura <j-nomura@...jp.nec.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html