netdev - Re: [PATCH ipsec] xfrm: release dst_orig in case of error in xfrm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150212095004.GI13046@secunet.com>
Date:	Thu, 12 Feb 2015 10:50:04 +0100
From:	Steffen Klassert <steffen.klassert@...unet.com>
To:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
CC:	<herbert@...dor.apana.org.au>, <davem@...emloft.net>,
	<netdev@...r.kernel.org>, huaibin Wang <huaibin.wang@...nd.com>
Subject: Re: [PATCH ipsec] xfrm: release dst_orig in case of error in
 xfrm_lookup()

On Wed, Feb 11, 2015 at 06:10:36PM +0100, Nicolas Dichtel wrote:
> From: huaibin Wang <huaibin.wang@...nd.com>
> 
> dst_orig should be released on error. Function like __xfrm_route_forward()
> expects that behavior.
> Since a recent commit, xfrm_lookup() may also be called by xfrm_lookup_route(),
> which expects the opposite.
> Let's introduce a new flag (XFRM_LOOKUP_KEEP_DST_REF) to tell what should be
> done in case of error.
> 
> Fixes: f92ee61982d("xfrm: Generate blackhole routes only from route lookup functions")
> Signed-off-by: huaibin Wang <huaibin.wang@...nd.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

Applied, thanks everyone!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html