netdev - Re: [PATCH net-next] openvswitch: Fix key serialization.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALnjE+pZ2mxMhcJiaP9V4YOSLDrvO-Hi_Om2Fu7QTQhX1N9B8g@mail.gmail.com>
Date:	Thu, 12 Feb 2015 12:41:43 -0800
From:	Pravin Shelar <pshelar@...ira.com>
To:	Joe Stringer <joestringer@...ira.com>
Cc:	David Miller <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] openvswitch: Fix key serialization.

On Thu, Feb 12, 2015 at 11:02 AM, Joe Stringer <joestringer@...ira.com> wrote:
> On 12 February 2015 at 09:58, Pravin B Shelar <pshelar@...ira.com> wrote:
>> Fix typo where mask is used rather than key.
>>
>> Fixes: 74ed7ab9264("openvswitch: Add support for unique flow IDs.")
>> Reported-by: Joe Stringer <joestringer@...ira.com>
>> Signed-off-by: Pravin B Shelar <pshelar@...ira.com>
>> ---
>
> Thanks for looking into this. So in general we zero-initialize the
> key, but not the mask---then use the key to determine which parts of
> the key (or mask) to serialize?
>
Mask is also initialized in ovs_match_init().


> This fixes the problem I was seeing.
>
> Acked-by: Joe Stringer <joestringer@...ira.com>

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html