lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <7F861DC0615E0C47A872E6F3C5FCDDBD05E2E9CE@BPXM14GP.gisp.nec.co.jp> Date: Fri, 13 Feb 2015 04:44:39 +0000 From: Hiroshi Shimamoto <h-shimamoto@...jp.nec.com> To: "Skidmore, Donald C" <donald.c.skidmore@...el.com>, "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com> CC: Alexander Duyck <alexander.duyck@...il.com>, Bjørn Mork <bjorn@...k.no>, "e1000-devel@...ts.sourceforge.net" <e1000-devel@...ts.sourceforge.net>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Choi, Sy Jong" <sy.jong.choi@...el.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, David Laight <David.Laight@...LAB.COM>, Hayato Momma <h-momma@...jp.nec.com> Subject: RE: [E1000-devel] [PATCH 1/3] ixgbe, ixgbevf: Add new mbox API to enable MC promiscuous mode > > > -----Original Message----- > > > From: Hiroshi Shimamoto [mailto:h-shimamoto@...jp.nec.com] > > > Sent: Monday, February 09, 2015 6:29 PM > > > To: Kirsher, Jeffrey T > > > Cc: Alexander Duyck; Skidmore, Donald C; Bjørn Mork; e1000- > > > devel@...ts.sourceforge.net; netdev@...r.kernel.org; Choi, Sy Jong; linux- > > > kernel@...r.kernel.org; David Laight; Hayato Momma > > > Subject: RE: [E1000-devel] [PATCH 1/3] ixgbe, ixgbevf: Add new mbox API to > > > enable MC promiscuous mode > > > > > > > > > > Can you please fix up your patches based on my tree: > > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/queue.git > > > > > > > > > > > > Yes. I haven't noticed your tree. > > > > > > Will resend patches against it. > > > > > > > > > > > > > > > > I encountered an issue with your tree, the commit id is below. > > > > > > > > > > $ git log | head > > > > > commit e6f1649780f8f5a87299bf6af04453f93d1e3d5e > > > > > Author: Rasmus Villemoes <linux@...musvillemoes.dk> > > > > > Date: Fri Jan 23 20:43:14 2015 -0800 > > > > > > > > > > ethernet: fm10k: Actually drop 4 bits > > > > > > > > > > The comment explains the intention, but vid has type u16. Before the > > > > > inner shift, it is promoted to int, which has plenty of space for all > > > > > vid's bits, so nothing is dropped. Use a simple mask instead. > > > > > > > > > > > > > > > I use the kernel from your tree in both host and guest. > > > > > > > > > > Assign an IPv6 for VF in guest. > > > > > # ip -6 addr add 2001:db8::18:1/64 dev ens0 > > > > > > > > > > Send ping packet from other server to the VM. > > > > > # ping6 2001:db8::18:1 -I eth0 > > > > > > > > > > The following message was shown. > > > > > ixgbevf 0000:00:08.0: partial checksum but l4 proto=3a! > > > > > > > > > > If I did the same operation in the host, I saw the same error message in > > > host too. > > > > > ixgbe 0000:2d:00.0: partial checksum but l4 proto=3a! > > > > > > > > > > Do you have any idea about that? > > > > > > > > Ah, sorry about that, try this tree again: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/queue.git > > > > > > > > That patch was dropped for favor of a patch that Matthew Vick put > > > > together (and recently got pushed upstream). So my queue no longer > > > > has that patch in the queue, since it got dropped. > > > > > > I still see the same error, the head id is the below > > > > > > $ git log | head > > > commit a072afb0b45904022b76deef3b770ee9a93cb13a > > > Author: Nicholas Krause <xerofoify@...il.com> > > > Date: Mon Feb 9 00:27:00 2015 -0800 > > > > > > igb: Remove outdated fix me comment in the > > > function,gb_acquire_swfw_sync_i210 > > > > > > > > > thanks, > > > Hiroshi > > > > I'm having our validation see if they can recreate the same issue internally. When they get back to me I'll let you > know > > what we found. > > We did bisect, and the below looks the culprit; > > 32dce968dd987adfb0c00946d78dad9154f64759 is the first bad commit > commit 32dce968dd987adfb0c00946d78dad9154f64759 > Author: Vlad Yasevich <vyasevich@...il.com> > Date: Sat Jan 31 10:40:18 2015 -0500 > > ipv6: Allow for partial checksums on non-ufo packets > > Currntly, if we are not doing UFO on the packet, all UDP > packets will start with CHECKSUM_NONE and thus perform full > checksum computations in software even if device support > IPv6 checksum offloading. > > Let's start start with CHECKSUM_PARTIAL if the device > supports it and we are sending only a single packet at > or below mtu size. > > Signed-off-by: Vladislav Yasevich <vyasevic@...hat.com> > Signed-off-by: David S. Miller <davem@...emloft.net> > > :040000 040000 4437eaf7e944f5a6136ebf668a256fee688fda3d fade8da998d35c8da97a15f0556949ad371e5347 M net When I reverted the commit, the issue was solved. thanks, Hiroshi
Powered by blists - more mailing lists