lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <87fvaa5ixe.fsf@free.fr> Date: Fri, 13 Feb 2015 09:12:29 +0100 From: Robert Jarzmik <robert.jarzmik@...e.fr> To: Linus Walleij <linus.walleij@...aro.org> Cc: Nicolas Pitre <nico@...xnic.net>, "David S. Miller" <davem@...emloft.net>, "netdev\@vger.kernel.org" <netdev@...r.kernel.org>, "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] Revert "smc91x: retrieve IRQ and trigger flags in a modern way" Linus Walleij <linus.walleij@...aro.org> writes: > On Fri, Feb 13, 2015 at 12:59 AM, Robert Jarzmik <robert.jarzmik@...e.fr> wrote: > But isn't the real problem that in the device tree case, > irq_get_irq_data(ndev->irq) will work becaus parsing an interrupt > from the device tree populates it correctly in platform_get_irq() > whereas for the legacy lookup it just fetches the number. > > So to me it seems like a weakness in the platform_get_irq() > helper altogether. > > Does the following work? (I can send as a separate patch for > testing if you like). I will test this evening (GMT+1 time), I feel this will work, and that this solution looks better to me than the sheer revert. I don't ask for a separate patch, yet if it is confirmed that it works, you'll have to submit it anyway :) Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists