netdev - Re: Possible Bug in gnet_start_copy_compat for the file,gen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpXo+LN9LC1U_kJbn1Kjw0CRzW6VaNw5OhgCS2qteqeQXg@mail.gmail.com>
Date:	Thu, 12 Feb 2015 19:01:11 -0800
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	nick <xerofoify@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	john fastabend <john.fastabend@...il.com>,
	standby24x7@...il.com, rdunlap@...radead.org,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: Possible Bug in gnet_start_copy_compat for the file,gen_stats.c

On Thu, Feb 12, 2015 at 6:33 PM, nick <xerofoify@...il.com> wrote:
> Greets to Everyone,
> I am wondering after running sparse on the latest mainline tree why we are not unlocking the  spinlock_bh,lock when calling the function,
> gnet_stats_start_copy_compat at the end of this function's body. Unless someone can explain to me why there is a very good reason for not
> unlocking the spinlock_bh,lock at the end of this function I will send in a patch fixing this. I am assuming this is a bug due to us infinitely
> looping in the spinlock_bh and deadlocking unless we exit this lock external to the call to the function,gnet_start_copy_compat.

The last time I looked at this, there is some place calling unlock,
you need to find it out. I don't think anyone touched it ever since
that time.

Let me know if you still can't find it. And yes, that code is kinda
messy, I _do_ have a patch to clean it up (not sent out yet).
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html