lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150213212830.GA29912@electric-eye.fr.zoreil.com> Date: Fri, 13 Feb 2015 22:28:30 +0100 From: Francois Romieu <romieu@...zoreil.com> To: Zhu Yanjun <Yanjun.Zhu@...driver.com> Cc: netdev@...r.kernel.org, mst@...hat.com, jasowang@...hat.com, viro@...iv.linux.org.uk, davem@...emloft.net, sergei.shtylyov@...entembedded.com, jonathon.reinhart@...il.com Subject: Re: [PATCH 1/1] tun: change speed from 10M to dynamically configured Zhu Yanjun <Yanjun.Zhu@...driver.com> : > The default speed of normal nic is 1000M while the default speed > of tun is 10M. Now the default speed of tun is changed to 1000M. > And there are 3 options: 10M, 100M and 1000M to the speed of tun. > The command "ethtool -s tun0 speed 10/100/1000" can configure the > speed of tun dynamically. You don't explain why this patch is needed. Why should tun_set_settings filter speed this way/at all ? There's no reason to pollute uapi .h file. -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists