lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150214195607.GA30752@casper.infradead.org> Date: Sat, 14 Feb 2015 19:56:07 +0000 From: Thomas Graf <tgraf@...g.ch> To: Joe Stringer <joestringer@...ira.com> Cc: netdev@...r.kernel.org, Justin Pettit <jpettit@...ira.com>, Pablo Neira Ayuso <pablo@...filter.org>, dev@...nvswitch.org Subject: Re: [RFC net-next 3/4] openvswitch: Add conntrack action. On 02/14/15 at 12:13am, Joe Stringer wrote: [..] > +static bool skb_has_valid_nfct(const struct net *net, u16 zone, > + const struct sk_buff *skb) > +{ > + enum ip_conntrack_info ctinfo; > + struct nf_conn *ct = nf_ct_get(skb, &ctinfo); > + > + if (!ct) > + return false; > + if (!net_eq(net, ct->ct_net)) > + return false; I'm surprised that this is needed. Shouldn't we call skb_scrub_packet() between namespaces and invalidate the ct associated with the skb. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists